Skip to content

Reapply "deps: bump node to v22.16.0 (#93080)" #93645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025
Merged

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Jun 16, 2025

Reapply node version bump, but preserve .volta.json so we can maintain backcompat with getsentry

@JonasBa JonasBa requested review from a team as code owners June 16, 2025 19:14
@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Jun 16, 2025
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@joshuarli joshuarli merged commit 97aa01e into master Jun 16, 2025
69 checks passed
@joshuarli joshuarli deleted the jb/node/22.16 branch June 16, 2025 19:40
@asottile-sentry asottile-sentry added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Jun 16, 2025
@getsentry-bot
Copy link
Contributor

PR reverted: f89d26e

getsentry-bot added a commit that referenced this pull request Jun 16, 2025
JonasBa added a commit that referenced this pull request Jun 17, 2025
JonasBa added a commit that referenced this pull request Jun 17, 2025
…3698)

This reverts commit f89d26e.

This should now be safe to merge, as getsentry has already been bumped
to 22.16

@joshuarli this change picks the .volta.json -> .node-version change,
but does not actually remove the .volta.json
getsentry-bot added a commit that referenced this pull request Jun 17, 2025
JonasBa added a commit that referenced this pull request Jun 17, 2025
billyvg pushed a commit that referenced this pull request Jun 18, 2025
Reapply node version bump, but preserve .volta.json so we can maintain
backcompat with getsentry
billyvg pushed a commit that referenced this pull request Jun 18, 2025
billyvg pushed a commit that referenced this pull request Jun 18, 2025
…3698)

This reverts commit f89d26e.

This should now be safe to merge, as getsentry has already been bumped
to 22.16

@joshuarli this change picks the .volta.json -> .node-version change,
but does not actually remove the .volta.json
billyvg pushed a commit that referenced this pull request Jun 18, 2025
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
Reapply node version bump, but preserve .volta.json so we can maintain
backcompat with getsentry
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
…3698)

This reverts commit f89d26e.

This should now be safe to merge, as getsentry has already been bumped
to 22.16

@joshuarli this change picks the .volta.json -> .node-version change,
but does not actually remove the .volta.json
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants