fix(ui): fix sticky headers in grideditable #93648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
TkDodo
reviewed
Jun 17, 2025
| @@ -486,7 +487,7 @@ class GridEditable< | |||
| height={height} | |||
| ref={this.refGrid} | |||
| > | |||
| <GridHead>{this.renderGridHead()}</GridHead> | |||
| <GridHead sticky={stickyHeader}>{this.renderGridHead()}</GridHead> | |||
There was a problem hiding this comment.
it seems like we pass sticky in two places now - to GridHead and to each GridHeadCell:
sentry/static/app/components/gridEditable/index.tsx
Lines 353 to 357 in f3b8437
Shouldn’t it be enough to pass it to GridHead now ? Your PR description also mentions you’ve moved where the sticky style gets applied - but I don’t see it being moved, only being added a second time 🤔.
There was a problem hiding this comment.
Woops forgot to remove that, thanks for the catch
TkDodo
approved these changes
Jun 17, 2025
billyvg
pushed a commit
that referenced
this pull request
Jun 18, 2025
### Changes Move where the sticky style gets applied to fix issues with sticky header not working with scrolling. Also add a story to cover both sticky headers and scrolling ### Before  ### After 
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
### Changes Move where the sticky style gets applied to fix issues with sticky header not working with scrolling. Also add a story to cover both sticky headers and scrolling ### Before  ### After 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Move where the sticky style gets applied to fix issues with sticky header not working with scrolling. Also add a story to cover both sticky headers and scrolling
Before
After