fix(detectors): Update SQL Injection Regex #93650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93650 +/- ##
==========================================
+ Coverage 83.12% 88.03% +4.91%
==========================================
Files 10324 10324
Lines 595574 595578 +4
Branches 23135 23135
==========================================
+ Hits 495045 524321 +29276
+ Misses 100035 70763 -29272
Partials 494 494 |
nora-shap
approved these changes
Jun 16, 2025
billyvg
pushed a commit
that referenced
this pull request
Jun 18, 2025
the previous regex prevented matching strings like `accounts` if the key/value was `account` but didn't catch things like `account.id` which would lead to too many potential replacements. the new regex should do a better job at this and add a test in for it.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
the previous regex prevented matching strings like `accounts` if the key/value was `account` but didn't catch things like `account.id` which would lead to too many potential replacements. the new regex should do a better job at this and add a test in for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the previous regex prevented matching strings like
accountsif the key/value wasaccountbut didn't catch things likeaccount.idwhich would lead to too many potential replacements. the new regex should do a better job at this and add a test in for it.