feat: add filter options for TA table when clicking on summary items #93654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
| @@ -68,7 +72,7 @@ export function useInfiniteTestResults() { | |||
| >({ | |||
| queryKey: [ | |||
| `/prevent/owner/${integratedOrg}/repository/${repository}/test-results/`, | |||
| {query: {branch, codecovPeriod, signedSortBy}}, | |||
| {query: {branch, codecovPeriod, signedSortBy, mappedFilterBy}}, | |||
There was a problem hiding this comment.
We don't care about If mappedFilteredBy ends up being one of these values here right?
uncoveredLines: 'UNCOVERED_LINES',
indirectChanges: 'INDIRECT_CHANGES',
filesChanged: 'FILES_CHANGED',
uploadsCount: 'UPLOAD_COUNT',
since this is inside of the useGetTestResults hook?
There was a problem hiding this comment.
Yeah that's true. I updated the PR to only populate mappedFilterBy with values that correspond to the TA summary specific values
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
…93654) This PR adds the ability to filter the Test Analytics table by the selections of the Test Analytics Summary cards. Notes - - Added the `filterBy` query param to talk to the backend. - Added object that maps filter selections to those that the backend expects. - Adjusted `f_b_type` to `filterBy` and related tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to filter the Test Analytics table by the selections of the Test Analytics Summary cards.
Notes
filterByquery param to talk to the backend.f_b_typetofilterByand related tests.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.