fix(aci): make snuba query validator timeWindow in seconds #93656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
kcons
reviewed
Jun 16, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93656 +/- ##
==========================================
- Coverage 79.41% 79.19% -0.22%
==========================================
Files 10324 10324
Lines 595767 595706 -61
Branches 23137 23132 -5
==========================================
- Hits 473113 471793 -1320
- Misses 122161 123420 +1259
Partials 493 493 |
ceorourke
reviewed
Jun 17, 2025
ceorourke
approved these changes
Jun 17, 2025
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
we store the timeWindow in seconds, so we should just have the validator accept seconds unfortunately the alert rule endpoints also share this serializer and i don't want to change their behavior, so we have to pass in a `timeWindowSeconds` param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we store the timeWindow in seconds, so we should just have the validator accept seconds
unfortunately the alert rule endpoints also share this serializer and i don't want to change their behavior, so we have to pass in a
timeWindowSecondsparam