Skip to content

fix(replay): fix event parser for breadcrumbs for resource fetch event #93657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2025

Conversation

michellewzhang
Copy link
Member

fixes SENTRY-415N

@michellewzhang michellewzhang requested a review from a team as a code owner June 16, 2025 20:56
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 16, 2025
Copy link
Member

@cmanallen cmanallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we couldn't extract sizes should we return "unknown" values in the log message? Seems like its not useful context.

Copy link

codecov bot commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #93657      +/-   ##
==========================================
+ Coverage   83.12%   88.03%   +4.91%     
==========================================
  Files       10324    10325       +1     
  Lines      595574   595593      +19     
  Branches    23135    23135              
==========================================
+ Hits       495045   524333   +29288     
+ Misses     100035    70766   -29269     
  Partials      494      494              

@michellewzhang
Copy link
Member Author

If we couldn't extract sizes should we return "unknown" values in the log message? Seems like its not useful context.

true, i can remove it from the log message if it's unknown

@michellewzhang michellewzhang merged commit 4359c25 into master Jun 16, 2025
63 checks passed
@michellewzhang michellewzhang deleted the mz/fix-event-parser branch June 16, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants