perf(aci): Batch redis operations #93658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93658 +/- ##
===========================================
+ Coverage 46.31% 88.02% +41.70%
===========================================
Files 10310 10327 +17
Lines 594449 595756 +1307
Branches 23127 23127
===========================================
+ Hits 275320 524393 +249073
+ Misses 318636 70870 -247766
Partials 493 493 |
cathteng
approved these changes
Jun 16, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
When process_workflow_engine is reported as slow, traces show 60-75% of the time being spent performing the many redis operations. Batching our redis operations should avoid some of the overhead from these many round-trips.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When process_workflow_engine is reported as slow, traces show 60-75% of the time being spent performing the many redis operations.
Batching our redis operations should avoid some of the overhead from these many round-trips.