Skip to content

fix(aci): Freeze UniqueConditionQuery filters to make them hashable #93664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025

Conversation

kcons
Copy link
Member

@kcons kcons commented Jun 16, 2025

When the filters are None, it's not a problem, but as soon as we populate it with a list of dicts, it's a runtime error.

@kcons kcons requested a review from cathteng June 16, 2025 21:57
@kcons kcons requested a review from a team as a code owner June 16, 2025 21:57
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 16, 2025
Copy link
Member

@cathteng cathteng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@kcons kcons merged commit 85f238f into master Jun 16, 2025
64 checks passed
@kcons kcons deleted the kcons/freeze branch June 16, 2025 22:48
billyvg pushed a commit that referenced this pull request Jun 18, 2025
…93664)

When the filters are `None`, it's not a problem, but as soon as we
populate it with a list of dicts, it's a runtime error.
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
…93664)

When the filters are `None`, it's not a problem, but as soon as we
populate it with a list of dicts, it's a runtime error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants