Skip to content

feat(ACI): Enable and disable detectors #93673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025

Conversation

ceorourke
Copy link
Member

When we enable and disable alert rules we want to do the same for detectors. There will be a follow up getsentry PR to handle this on that side for when it's just detectors and we're not looking it up through the lookup table.

@ceorourke ceorourke requested a review from a team as a code owner June 16, 2025 23:54
@ceorourke ceorourke requested a review from a team June 16, 2025 23:55
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 16, 2025
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/incidents/logic.py 83.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #93673       +/-   ##
===========================================
+ Coverage   46.37%   88.02%   +41.65%     
===========================================
  Files       10312    10328       +16     
  Lines      595254   596006      +752     
  Branches    23153    23153               
===========================================
+ Hits       276041   524644   +248603     
+ Misses     318720    70869   -247851     
  Partials      493      493               

@ceorourke ceorourke force-pushed the ceorourke/enable-disable-detectors branch from 6b5657d to 40af8e0 Compare June 17, 2025 17:08
@ceorourke ceorourke merged commit 96ec9db into master Jun 17, 2025
63 checks passed
@ceorourke ceorourke deleted the ceorourke/enable-disable-detectors branch June 17, 2025 17:28
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
When we enable and disable alert rules we want to do the same for
detectors. There will be a follow up getsentry PR to handle this on that
side for when it's just detectors and we're not looking it up through
the lookup table.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants