chore: Add 'last_seen' and 'times_seen' columns to table grouptombstone

[priscilawebdev]

Contributes to https://linear.app/getsentry/issue/TET-595/display-discarded-issue-count-and-timestamp-for-each-entry-in

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #93682       +/-   ##
===========================================
+ Coverage   76.56%   88.03%   +11.46%     
===========================================
  Files       10338    10341        +3     
  Lines      597261   597010      -251     
  Branches    23193    23138       -55     
===========================================
+ Hits       457316   525599    +68283     
+ Misses     139484    70955    -68529     
+ Partials      461      456        -5     

[vgrozdanic]

Blocking the merge since this can cause some problems

[github-actions]

This PR has a migration; here is the generated SQL for src/sentry/migrations/0930_add_hit_counter_columns_to_grouptombstone.py

for 0930_add_hit_counter_columns_to_grouptombstone in sentry

--
-- Add field last_seen to grouptombstone
--
ALTER TABLE "sentry_grouptombstone" ADD COLUMN "last_seen" timestamp with time zone NULL;
--
-- Add field times_seen to grouptombstone
--
ALTER TABLE "sentry_grouptombstone" ADD COLUMN "times_seen" integer DEFAULT 0 NOT NULL CHECK ("times_seen" >= 0);

[wedamija]

Nit: for last_seen, If you just want the default to be None, you don't need to include this default at all.

If you want it to just be set to the current date/time when the row is first created, you can use auto_now_add=True instead of using a default.

[priscilawebdev]

I was planning to write another migration just to do that for new future records (rows), and you just saved me from that! thank youuu

[priscilawebdev]

ok unfortunately this does not work the way I expected. I would like existing rows to be null and future rows to have a timestamp. There is no another way but creating 2 migrations for that

[github-actions]

This PR has a migration; here is the generated SQL for src/sentry/migrations/0931_add_hit_counter_columns_to_grouptombstone.py

for 0931_add_hit_counter_columns_to_grouptombstone in sentry

--
-- Add field last_seen to grouptombstone
--
ALTER TABLE "sentry_grouptombstone" ADD COLUMN "last_seen" timestamp with time zone NULL;
--
-- Add field times_seen to grouptombstone
--
ALTER TABLE "sentry_grouptombstone" ADD COLUMN "times_seen" integer DEFAULT 0 NOT NULL CHECK ("times_seen" >= 0);