fix(ui): linkButton focus state #93683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this overwrites global styles that we probably shouldn't have
github-actions
bot
added
the
Scope: Frontend
JonasBa
approved these changes
Jun 17, 2025
billyvg
pushed a commit
that referenced
this pull request
Jun 18, 2025
the real issue are these global styles for all `a` tags: https://github.com/getsentry/sentry/blob/3c99300d6c73ff31a6f1866000fb9dcb6e56f3b0/static/app/styles/global.tsx#L145-L151 However, removing them (even just for `chonk`) has a negative impact in many places. What we would likely need is an isolated `<Link>` component that sets all its styles rather than relying on global styles to affect it. So this is more of a band-aid fix, as I’m just setting the same color while focusing, which overwrites the global one.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
the real issue are these global styles for all `a` tags: https://github.com/getsentry/sentry/blob/3c99300d6c73ff31a6f1866000fb9dcb6e56f3b0/static/app/styles/global.tsx#L145-L151 However, removing them (even just for `chonk`) has a negative impact in many places. What we would likely need is an isolated `<Link>` component that sets all its styles rather than relying on global styles to affect it. So this is more of a band-aid fix, as I’m just setting the same color while focusing, which overwrites the global one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the real issue are these global styles for all
atags:sentry/static/app/styles/global.tsx
Lines 145 to 151 in 3c99300
However, removing them (even just for
chonk) has a negative impact in many places. What we would likely need is an isolated<Link>component that sets all its styles rather than relying on global styles to affect it.So this is more of a band-aid fix, as I’m just setting the same color while focusing, which overwrites the global one.