fix(ui): select menu positioning #93684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the `...provided` spread will give us top/bottom 100% depending on where the menu should be opened, so the hardcoded top:100% is harmful; also, margin top/bottom is provided already
github-actions
bot
added
the
Scope: Frontend
JonasBa
approved these changes
Jun 17, 2025
TkDodo
deleted the
tkdodo/fix/de-81-buggy-select-component-dropdown-behavior
branch
billyvg
pushed a commit
that referenced
this pull request
Jun 18, 2025
the `...provided` spread will give us top/bottom 100% depending on where the menu should be opened, so the hardcoded top:100% is harmful; also, margin top/bottom is provided already | before | after | |--------|--------| |  |  |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
the `...provided` spread will give us top/bottom 100% depending on where the menu should be opened, so the hardcoded top:100% is harmful; also, margin top/bottom is provided already | before | after | |--------|--------| |  |  |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
...providedspread will give us top/bottom 100% depending on where the menu should be opened, so the hardcoded top:100% is harmful; also, margin top/bottom is provided already