feat: Add logic to increment GroupTombstone hits asynchronously #93685
+67
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## priscila/chore/add-hit-tracker-columns-to-grouptombstone #93685 +/- ##
============================================================================================
+ Coverage 88.03% 88.05% +0.01%
============================================================================================
Files 10331 10329 -2
Lines 596251 596082 -169
Branches 23150 23116 -34
============================================================================================
- Hits 524901 524867 -34
+ Misses 70899 70722 -177
- Partials 451 493 +42 |
github-actions
bot
added
the
Scope: Frontend
priscilawebdev
force-pushed
the
priscila/feat/add-logic-to-update-hit-counter-columns-in-grouptomstone
branch
from
1de5ba6 to
ca9ff99
Compare
priscilawebdev
force-pushed
the
priscila/feat/add-logic-to-update-hit-counter-columns-in-grouptomstone
branch
from
ca9ff99 to
07b527b
Compare
priscilawebdev
force-pushed
the
priscila/feat/add-logic-to-update-hit-counter-columns-in-grouptomstone
branch
from
07b527b to
3a650ec
Compare
priscilawebdev
removed
the
Scope: Frontend
markstory
reviewed
Jun 17, 2025
src/sentry/event_manager.py
Outdated
| group_tombstone = GroupTombstone.objects.get(id=tombstone_id) | ||
| buffer_incr( | ||
| GroupTombstone, | ||
| {"times_seen": group_tombstone.times_seen + 1 if group_tombstone.times_seen else 1}, |
There was a problem hiding this comment.
You don't want to include the current count here. Instead only pass 1 here. The buffers system will generate F(column) + value when the buffered values are flushed to postgres.
There was a problem hiding this comment.
yes just noticed that. that is why the test broke :)
Comment on lines
2139
to
2143
| with mock.patch("sentry.event_manager.track_outcome", mock_track_outcome): | ||
| with self.feature("organizations:event-attachments"): | ||
| with self.tasks(): | ||
| with self.feature("organizations:grouptombstones-hit-counter"): | ||
| with pytest.raises(HashDiscarded): |
There was a problem hiding this comment.
You could combine all of these
with (
mock.patch(...),
self.feature(...)
):which can help with the indentation levels.
…e' into priscila/feat/add-logic-to-update-hit-counter-columns-in-grouptomstone
…e' into priscila/feat/add-logic-to-update-hit-counter-columns-in-grouptomstone
wedamija
approved these changes
Jun 17, 2025
…e' into priscila/feat/add-logic-to-update-hit-counter-columns-in-grouptomstone
…e' into priscila/feat/add-logic-to-update-hit-counter-columns-in-grouptomstone
JoshFerge
reviewed
Jun 18, 2025
| @@ -294,6 +294,31 @@ def get_stored_crashreports(cache_key: str | None, event: Event, max_crashreport | |||
| return query[:max_crashreports].count() | |||
|
|
|||
|
|
|||
| def increment_group_tombstone_hit_counter(tombstone_id: int | None, event: Event) -> None: | |||
| if tombstone_id: | |||
There was a problem hiding this comment.
nit: prefer return early to minimize code arrowing, e.g. if not tombstone_id return
JoshFerge
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to https://linear.app/getsentry/issue/TET-595/display-discarded-issue-count-and-timestamp-for-each-entry-in