fix(ui): colors for banner styles #93687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colors for alert-banner.default was inherited from the body, which worked in light mode, but not in dark mode setting the colors explicitly works for both, as the background-color is a hardcoded yellow
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93687 +/- ##
===========================================
+ Coverage 34.33% 88.03% +53.69%
===========================================
Files 9760 10325 +565
Lines 550747 595579 +44832
Branches 23137 23135 -2
===========================================
+ Hits 189103 524296 +335193
+ Misses 360997 70790 -290207
+ Partials 647 493 -154 |
obostjancic
approved these changes
Jun 17, 2025
JonasBa
approved these changes
Jun 17, 2025
|
not sure what to do with the backend failures here? |
TkDodo
deleted the
tkdodo/fix/de-125-glitch-with-banner-styles-during-login
branch
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
colors for alert-banner.default was inherited from the body, which worked in light mode, but not in dark mode setting the colors explicitly works for both, as the background-color is a hardcoded yellow | before | after | |--------|--------| |  |  |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
colors for alert-banner.default was inherited from the body, which worked in light mode, but not in dark mode
setting the colors explicitly works for both, as the background-color is a hardcoded yellow