Skip to content

fix(ui): arcade element in dark mode #93689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TkDodo
Copy link
Contributor

@TkDodo TkDodo commented Jun 17, 2025

this isn't UI2 related, as this was also not nice in the old UI in dark mode. There's no difference in light mode.

before after
Screenshot 2025-06-17 at 11 51 17 Screenshot 2025-06-17 at 11 51 40
Screenshot 2025-06-17 at 11 51 35 Screenshot 2025-06-17 at 11 51 24

this isn't UI2 related, as this was also not nice in the old UI in dark mode
@TkDodo TkDodo marked this pull request as ready for review June 17, 2025 09:56
@TkDodo TkDodo requested a review from a team June 17, 2025 09:56
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 17, 2025
@TkDodo TkDodo merged commit 1c0a200 into master Jun 17, 2025
46 checks passed
@TkDodo TkDodo deleted the tkdodo/fix/de-110-unintentional-background-of-arcade-element branch June 17, 2025 13:36
billyvg pushed a commit that referenced this pull request Jun 18, 2025
this isn't UI2 related, as this was also not nice in the old UI in dark
mode. There's no difference in light mode.

| before | after |
|--------|--------|
| ![Screenshot 2025-06-17 at 11 51
17](https://github.com/user-attachments/assets/7ffb1ceb-f3b8-4102-988c-5f8192f0729e)
| ![Screenshot 2025-06-17 at 11 51
40](https://github.com/user-attachments/assets/b4dade40-af20-4aa1-8715-4d64c697cb80)
|
| ![Screenshot 2025-06-17 at 11 51
35](https://github.com/user-attachments/assets/bd4fba77-84ae-44a3-b356-46cd4406663d)
| ![Screenshot 2025-06-17 at 11 51
24](https://github.com/user-attachments/assets/508d3d9e-cab6-4ef0-a3a7-3b774ac20a13)
|
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
this isn't UI2 related, as this was also not nice in the old UI in dark
mode. There's no difference in light mode.

| before | after |
|--------|--------|
| ![Screenshot 2025-06-17 at 11 51
17](https://github.com/user-attachments/assets/7ffb1ceb-f3b8-4102-988c-5f8192f0729e)
| ![Screenshot 2025-06-17 at 11 51
40](https://github.com/user-attachments/assets/b4dade40-af20-4aa1-8715-4d64c697cb80)
|
| ![Screenshot 2025-06-17 at 11 51
35](https://github.com/user-attachments/assets/bd4fba77-84ae-44a3-b356-46cd4406663d)
| ![Screenshot 2025-06-17 at 11 51
24](https://github.com/user-attachments/assets/508d3d9e-cab6-4ef0-a3a7-3b774ac20a13)
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants