-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(crash-detection): allow matching on frame.module
#93690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dope! want this for java/android frames now :)
Yeah cocoa is only used for the test here but this works for Java/Android too, so you can use it! |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93690 +/- ##
==========================================
+ Coverage 84.12% 88.04% +3.92%
==========================================
Files 10332 10329 -3
Lines 596302 596101 -201
Branches 23163 23119 -44
==========================================
+ Hits 501624 524859 +23235
+ Misses 94222 70749 -23473
- Partials 456 493 +37 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM. CI is still failing, though.
I think it was due to something else, let me update the branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM
Close #66689