Skip to content

feat(crash-detection): allow matching on frame.module #93690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

lcian
Copy link
Member

@lcian lcian commented Jun 17, 2025

Close #66689

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 17, 2025
Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dope! want this for java/android frames now :)

@lcian
Copy link
Member Author

lcian commented Jun 17, 2025

dope! want this for java/android frames now :)

Yeah cocoa is only used for the test here but this works for Java/Android too, so you can use it!
I'm adding this rule for Java, maybe I should see if there's other rules we could add #93692

Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #93690      +/-   ##
==========================================
+ Coverage   84.12%   88.04%   +3.92%     
==========================================
  Files       10332    10329       -3     
  Lines      596302   596101     -201     
  Branches    23163    23119      -44     
==========================================
+ Hits       501624   524859   +23235     
+ Misses      94222    70749   -23473     
- Partials      456      493      +37     

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. CI is still failing, though.

@lcian
Copy link
Member Author

lcian commented Jun 17, 2025

Thanks, LGTM. CI is still failing, though.

I think it was due to something else, let me update the branch.

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDK Detection: Allow ignoring crashes by stackframe.module
4 participants