Skip to content

feat: Expose last seen and times seen in the discarded issues table #93694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: priscila/feat/add-logic-to-update-hit-counter-columns-in-grouptomstone
Choose a base branch
from

Conversation

priscilawebdev
Copy link
Member

@priscilawebdev priscilawebdev commented Jun 17, 2025

@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Jun 17, 2025
@priscilawebdev priscilawebdev changed the title Priscila/feat/expose last seen and time seen in discarded issues table feat: Expose last seen and times seen in the discarded issues table Jun 17, 2025
@getsentry getsentry deleted a comment from github-actions bot Jun 17, 2025
@priscilawebdev priscilawebdev removed the Scope: Backend Automatically applied to PRs that change backend components label Jun 17, 2025
@priscilawebdev priscilawebdev marked this pull request as ready for review June 17, 2025 11:46
@priscilawebdev priscilawebdev requested a review from a team June 17, 2025 11:46
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                                             Coverage Diff                                             @@
##           priscila/feat/add-logic-to-update-hit-counter-columns-in-grouptomstone   #93694       +/-   ##
===========================================================================================================
+ Coverage                                                                   76.36%   86.81%   +10.45%     
===========================================================================================================
  Files                                                                       10327    10324        -3     
  Lines                                                                      596060   595266      -794     
  Branches                                                                    23116    23115        -1     
===========================================================================================================
+ Hits                                                                       455177   516788    +61611     
+ Misses                                                                     140390    77985    -62405     
  Partials                                                                      493      493               

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 17, 2025
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@priscilawebdev priscilawebdev force-pushed the priscila/feat/add-logic-to-update-hit-counter-columns-in-grouptomstone branch from 1de5ba6 to ca9ff99 Compare June 17, 2025 14:00
@priscilawebdev priscilawebdev requested a review from a team as a code owner June 17, 2025 14:00
@priscilawebdev priscilawebdev force-pushed the priscila/feat/add-logic-to-update-hit-counter-columns-in-grouptomstone branch from ca9ff99 to 07b527b Compare June 17, 2025 14:02
Copy link
Member

@armenzg armenzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible, please separate the UI and BE changes.

@priscilawebdev priscilawebdev force-pushed the priscila/feat/add-logic-to-update-hit-counter-columns-in-grouptomstone branch from 07b527b to 3a650ec Compare June 17, 2025 14:03
@priscilawebdev priscilawebdev force-pushed the priscila/feat/expose-last-seen-and-time-seen-in-discarded-issues-table branch from 446c931 to 41ab893 Compare June 17, 2025 14:05
@priscilawebdev priscilawebdev force-pushed the priscila/feat/expose-last-seen-and-time-seen-in-discarded-issues-table branch from 41ab893 to 39ef486 Compare June 17, 2025 14:07
@priscilawebdev priscilawebdev removed the Scope: Backend Automatically applied to PRs that change backend components label Jun 17, 2025
@priscilawebdev
Copy link
Member Author

priscilawebdev commented Jun 17, 2025

If possible, please separate the UI and BE changes.

They are separate, there were some issues with the rebase - it shall be fixed now :)

@armenzg
Copy link
Member

armenzg commented Jun 17, 2025

I will let someone else review the UI changes.

…n-grouptomstone' into priscila/feat/expose-last-seen-and-time-seen-in-discarded-issues-table
…n-grouptomstone' into priscila/feat/expose-last-seen-and-time-seen-in-discarded-issues-table
…n-grouptomstone' into priscila/feat/expose-last-seen-and-time-seen-in-discarded-issues-table
…n-grouptomstone' into priscila/feat/expose-last-seen-and-time-seen-in-discarded-issues-table
Copy link
Member

@ArthurKnaus ArthurKnaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants