Skip to content

Reapply "Reapply "deps: bump node to v22.16.0 (#93080)" (#93645)" #93698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 17, 2025

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Jun 17, 2025

This reverts commit f89d26e.

This should now be safe to merge, as getsentry has already been bumped to 22.16

@joshuarli this change picks the .volta.json -> .node-version change, but does not actually remove the .volta.json

@JonasBa JonasBa requested review from a team as code owners June 17, 2025 13:16
@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Jun 17, 2025
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #93698       +/-   ##
===========================================
+ Coverage   46.08%   76.73%   +30.64%     
===========================================
  Files       10309    10330       +21     
  Lines      595061   596046      +985     
  Branches    23137    23135        -2     
===========================================
+ Hits       274240   457369   +183129     
+ Misses     320328   137964   -182364     
- Partials      493      713      +220     

@JonasBa JonasBa enabled auto-merge (squash) June 17, 2025 14:31
@JonasBa JonasBa merged commit cf020ef into master Jun 17, 2025
68 checks passed
@JonasBa JonasBa deleted the jb/node/22.16.0 branch June 17, 2025 14:45
@JonasBa
Copy link
Member Author

JonasBa commented Jun 17, 2025

There is a dev cmd that was left behind, I'm going to revert this and reopen.

@JonasBa JonasBa added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Jun 17, 2025
@getsentry-bot
Copy link
Contributor

PR reverted: ae80641

getsentry-bot added a commit that referenced this pull request Jun 17, 2025
JonasBa added a commit that referenced this pull request Jun 17, 2025
billyvg pushed a commit that referenced this pull request Jun 18, 2025
…3698)

This reverts commit f89d26e.

This should now be safe to merge, as getsentry has already been bumped
to 22.16

@joshuarli this change picks the .volta.json -> .node-version change,
but does not actually remove the .volta.json
billyvg pushed a commit that referenced this pull request Jun 18, 2025
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
…3698)

This reverts commit f89d26e.

This should now be safe to merge, as getsentry has already been bumped
to 22.16

@joshuarli this change picks the .volta.json -> .node-version change,
but does not actually remove the .volta.json
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants