feat(profiling): Flag to test always using direct continuous profile … #93705
+74
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chunks Testing the strategy of always including direct continuous profile chunks. This was a concern previously on web servers where idle time was the majority of the flamegraph. But with lifecycle=trace, this is less of an issue. And by always including it, we can improve the situation where SDK devs are switching between lifecycle=trace and lifecycle=manual.
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #93705 +/- ##
==========================================
+ Coverage 85.47% 88.03% +2.56%
==========================================
Files 10320 10324 +4
Lines 595562 595780 +218
Branches 23137 23137
==========================================
+ Hits 509059 524499 +15440
+ Misses 86010 70788 -15222
Partials 493 493 |
phacops
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…chunks
Testing the strategy of always including direct continuous profile chunks. This was a concern previously on web servers where idle time was the majority of the flamegraph. But with lifecycle=trace, this is less of an issue.
And by always including it, we can improve the situation where SDK devs are switching between lifecycle=trace and lifecycle=manual.