fix(insights): fix profile link not generating properly on EAP #93706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
DominikB2014
approved these changes
Jun 17, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
This change fixes several issues with the profile link generation in the insights span samples panel: 1. Updates link generation to use existing utility functions instead (ie `generateProfileFlamechartRoute` and `generateContinuousProfileFlamechartRouteWithQuery`) 2. On the EAP dataset (ie `spans`), samples are returned with `profile.id` attributes instead of `profile_id`. Updates the link generation to check for either case. 3. Some samples come with a continuous profile instead (ie `profiler.id`). Updates to handle these scenarios as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes several issues with the profile link generation in the insights span samples panel:
generateProfileFlamechartRouteandgenerateContinuousProfileFlamechartRouteWithQuery)spans), samples are returned withprofile.idattributes instead ofprofile_id. Updates the link generation to check for either case.profiler.id). Updates to handle these scenarios as well.