Skip to content

feat(release): Remove release-bubbles-ui feature flag #93709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 17, 2025

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Jun 17, 2025

The release-bubbles-ui feature flag has been removed from the frontend codebase, enabling its functionality by default across various components.

Changes include:

  • In static/app/components/replays/releaseDropdownFilter.tsx and static/app/components/version.tsx, navigation to release details consistently uses makeReleaseDrawerPathname, removing the conditional check for the feature flag.
  • static/app/views/dashboards/widgets/timeSeriesWidget/timeSeriesWidgetVisualization.tsx and static/app/views/issueDetails/streamline/eventGraph.tsx no longer check the feature flag to determine if release bubbles should be shown.
  • static/app/views/insights/common/components/insightsTimeSeriesWidget.tsx, static/app/views/insights/pages/platform/shared/getReleaseBubbleProps.tsx, and static/app/views/performance/transactionSummary/transactionOverview/useWidgetChartVisualization.tsx now always pass props to enable release bubbles.
  • static/app/views/releases/releaseBubbles/useReleaseBubbles.tsx no longer relies on the feature flag for creating release buckets.
  • Unused imports, such as useOrganization and makeReleasesPathname, were removed, and conditional logic was simplified.

The frontend now consistently displays the modern release bubbles UI and uses the new release drawer. The backend feature flag definition was explicitly left unchanged.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 17, 2025
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #93709   +/-   ##
=======================================
  Coverage   88.01%   88.01%           
=======================================
  Files       10322    10322           
  Lines      595057   595042   -15     
  Branches    23125    23118    -7     
=======================================
- Hits       523725   523719    -6     
+ Misses      70839    70830    -9     
  Partials      493      493           

@billyvg billyvg marked this pull request as ready for review June 17, 2025 17:19
@billyvg billyvg requested review from a team as code owners June 17, 2025 17:19
Copy link
Member

@michellewzhang michellewzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@billyvg billyvg merged commit 2ec64ea into master Jun 17, 2025
46 checks passed
@billyvg billyvg deleted the cursor/remove-obsolete-feature-flag-02f1 branch June 17, 2025 18:49
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
The `release-bubbles-ui` feature flag has been removed from the frontend
codebase, enabling its functionality by default across various
components.

Changes include:
* In `static/app/components/replays/releaseDropdownFilter.tsx` and
`static/app/components/version.tsx`, navigation to release details
consistently uses `makeReleaseDrawerPathname`, removing the conditional
check for the feature flag.
*
`static/app/views/dashboards/widgets/timeSeriesWidget/timeSeriesWidgetVisualization.tsx`
and `static/app/views/issueDetails/streamline/eventGraph.tsx` no longer
check the feature flag to determine if release bubbles should be shown.
*
`static/app/views/insights/common/components/insightsTimeSeriesWidget.tsx`,
`static/app/views/insights/pages/platform/shared/getReleaseBubbleProps.tsx`,
and
`static/app/views/performance/transactionSummary/transactionOverview/useWidgetChartVisualization.tsx`
now always pass props to enable release bubbles.
* `static/app/views/releases/releaseBubbles/useReleaseBubbles.tsx` no
longer relies on the feature flag for creating release buckets.
* Unused imports, such as `useOrganization` and `makeReleasesPathname`,
were removed, and conditional logic was simplified.

The frontend now consistently displays the modern release bubbles UI and
uses the new release drawer. The backend feature flag definition was
explicitly left unchanged.

---------

Co-authored-by: Cursor Agent <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants