feat(replay): Debug replay summarizer failure #93714
Merged
+14
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Seer access logs, Seer responds with a 200, but this endpoint is somehow returning a `ParseError`. Add some logging when status_code is not 200.
github-actions
bot
added
the
Scope: Backend
billyvg
commented
Jun 17, 2025
| }, | ||
| ) | ||
|
|
||
| response.raise_for_status() |
There was a problem hiding this comment.
idk I see the other seer endpoints use this instead -- maybe we're getting a <400 status code?
There was a problem hiding this comment.
Probably overkill with the log above but its fine. This is internal any way.
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #93714 +/- ##
==========================================
+ Coverage 86.89% 88.03% +1.14%
==========================================
Files 10324 10326 +2
Lines 595768 595926 +158
Branches 23137 23137
==========================================
+ Hits 517672 524640 +6968
+ Misses 77603 70793 -6810
Partials 493 493 |
cmanallen
approved these changes
Jun 17, 2025
cmanallen
approved these changes
Jun 17, 2025
michellewzhang
approved these changes
Jun 17, 2025
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
In Seer access logs, Seer responds with a 200, but this endpoint is somehow returning a `ParseError`. Add some logging when status_code is not 200.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Seer access logs, Seer responds with a 200, but this endpoint is somehow returning a
ParseError. Add some logging when status_code is not 200.