feat(issues): Add parameterization for traceparent #93721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are currently parameterized as something like the following (redacted example): `<int>-<md5>-0a0000000000abcd<int>`. The regex here is intentionally strict and will only support the current version (`00`) to help ensure this is conservative in matching. See https://www.w3.org/TR/trace-context/#traceparent-header
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93721 +/- ##
==========================================
+ Coverage 88.00% 88.03% +0.02%
==========================================
Files 10322 10342 +20
Lines 594787 596506 +1719
Branches 23139 23139
==========================================
+ Hits 523450 525108 +1658
- Misses 70844 70905 +61
Partials 493 493 |
mrduncan
commented
Jun 18, 2025
| "url", | ||
| "hostname", | ||
| "ip", | ||
| "traceparent", |
There was a problem hiding this comment.
This line is the only difference from REGEX_PATTERN_KEYS above
armenzg
approved these changes
Jun 18, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
These are currently parameterized as something like the following which is unhelpful for grouping (redacted example): `<int>-<md5>-0a0000000000abcd<int>`. The regex here is intentionally strict and will only support the current version (`00`) to help ensure this is conservative in matching. The option for this is done outside of our normal path since we need the `traceparent` parameterization to happen before `int`/`md5` in the order of operations. Once this is rolled out, a follow-up PR will clean up quite a bit of our experiment logic here. See also: https://www.w3.org/TR/trace-context/#traceparent-header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are currently parameterized as something like the following which is unhelpful for grouping (redacted example):
<int>-<md5>-0a0000000000abcd<int>.The regex here is intentionally strict and will only support the current version (
00) to help ensure this is conservative in matching.The option for this is done outside of our normal path since we need the
traceparentparameterization to happen beforeint/md5in the order of operations. Once this is rolled out, a follow-up PR will clean up quite a bit of our experiment logic here.See also: https://www.w3.org/TR/trace-context/#traceparent-header