Skip to content

Reapply "ref: match pipeline arg name in auth views #93722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2025

Conversation

asottile-sentry
Copy link
Member

#93375 with fixes for auth views

@asottile-sentry asottile-sentry requested review from a team June 17, 2025 17:15
@asottile-sentry asottile-sentry requested review from a team as code owners June 17, 2025 17:15
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 17, 2025
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

Attention: Patch coverage is 54.76190% with 38 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/auth/providers/github/views.py 18.75% 13 Missing ⚠️
src/sentry/auth/providers/google/views.py 8.33% 11 Missing ⚠️
src/sentry/auth/providers/fly/views.py 20.00% 4 Missing ⚠️
src/sentry/auth/providers/saml2/generic/views.py 33.33% 4 Missing ⚠️
src/sentry/auth/providers/oauth2.py 86.66% 2 Missing ⚠️
src/sentry/auth/providers/saml2/views.py 33.33% 2 Missing ⚠️
src/sentry/auth/providers/saml2/provider.py 94.44% 1 Missing ⚠️
...c/sentry/auth/providers/saml2/rippling/provider.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #93722    +/-   ##
========================================
  Coverage   88.03%   88.03%            
========================================
  Files       10325    10326     +1     
  Lines      595795   595899   +104     
  Branches    23136    23136            
========================================
+ Hits       524503   524611   +108     
+ Misses      70799    70795     -4     
  Partials      493      493            

@asottile-sentry asottile-sentry merged commit b69880e into master Jun 18, 2025
65 checks passed
@asottile-sentry asottile-sentry deleted the asottile-pipeline-arg-name-try2 branch June 18, 2025 13:19
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
#93375 with fixes for auth views

<!-- Describe your PR here. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants