fix(otlp): Add attribute aliases for span name and kind
#93725
Conversation
These fields are top-level fields in span V2, and we want users to be able to search for them directly.
github-actions
bot
added
the
Scope: Backend
|
@shruthilayaj I removed that reverse alias, since I needed it to make the |
gggritso
changed the title
name, kind, and statusname and kind
We already have `span.status`, so let's do one thing at a time here.
|
Also, it seems like maybe these should be |
I think this should be safe to remove - it was temporarily needed while Pierre cleaned up the alias map on the EAP side (which has since been done). There were test failures last time, so if tests pass, you should be good. |
|
@shruthilayaj @Zylphrex should these be called |
That depends on how you'd like them to be exposed in the UI. Though I do think Also, does the OTLP span schema have any opinions how they should be exposed? |
|
@Zylphrex I don't think OTel has any opinions on how the telemetry platforms do things, OTel only cares about sending the data! My opinion is that people should be able to recognize the data they sent and be able to guess how to find it, but IMO |
|
If that's the case, then prefixing with |
gggritso
deleted the
georgegritsouk/ope-38-add-aliases-for-spanname-spankind-and-spanstatus-fields
branch
`kind`, `name`, and `status` are top-level fields in the Span V2 schema, and in the OTLP span schema. We expect users to be able to search for these fields in Explore with syntax like `"name:GET*"`. In EAP, these fields are stored as `sentry.kind` and `sentry.name` respectively. This PR adds the aliases, with a `span.` prefix to disambiguate. `span.status` is already aliased to `sentry.status` N.B. This PR also removes the reverse alias of from `sentry.name` to `span.description` from `SPANS_INTERNAL_TO_PUBLIC_ALIAS_MAPPINGS`! N.B.2. This is not feature-flagged but `name`, `kind`, and `status` aren't in the autocomplete for span searches, and _that_ will be feature-flagged.
kind,name, andstatusare top-level fields in the Span V2 schema, and in the OTLP span schema. We expect users to be able to search for these fields in Explore with syntax like"name:GET*". In EAP, these fields are stored assentry.kindandsentry.namerespectively. This PR adds the aliases, with aspan.prefix to disambiguate.span.statusis already aliased tosentry.statusN.B. This PR also removes the reverse alias of from
sentry.nametospan.descriptionfromSPANS_INTERNAL_TO_PUBLIC_ALIAS_MAPPINGS!N.B.2. This is not feature-flagged but
name,kind, andstatusaren't in the autocomplete for span searches, and that will be feature-flagged.