feat(codecov): Add step 3 steps for TA onboarding #93726
Conversation
github-actions
bot
added
the
Scope: Frontend
| @@ -59,6 +64,9 @@ export default function TestsOnboardingPage() { | |||
| /> | |||
| <AddUploadToken step="2b" /> | |||
| <AddPermissionsBlock step="2b" /> | |||
| <AddScriptToYaml step="3" /> | |||
There was a problem hiding this comment.
Confirming these should all be step 3 right, they're just different variants of it?
| {SNIPPET} | ||
| </CodeSnippet> | ||
| <p> | ||
| {t( |
There was a problem hiding this comment.
Two things
a) I think there's a bit of space missing between the code snippet and the next paragraph. This applies to all the "step 3s" that were added (In the "edit your github action workflow" one, the space missing is between the header and the following snippet) as well as step 2b
b) Does the "permissions" block seem weird to you here? It feels it's a bit lower than the rest of the text, is there a way to move it up like space(0.5)? This applies to all InlineCodeSnippets
There was a problem hiding this comment.
Overall lgtm, thanks for this 👌. I noticed some sentences end in period and some dont so maybe look out for those - granted our designs are also inconsistent in that way, but I think we should pick one or the other and do it the same for all (likely ending in a period).
calvin-codecov
force-pushed
the
cy/step3_ta_onboarding
branch
from
544fa40 to
236558b
Compare
|
I'm removing AddPermissionsBlock as it's actually part of editGHAWorkflow now. That step used to be 2 steps in one container but now has been modified in the Figma |
Closes https://linear.app/getsentry/issue/CCMRG-142/test-analytics-onboarding-gh-actions-repo-token-step-3
https://linear.app/getsentry/issue/CCMRG-138/test-analytics-onboarding-gh-actions-oidc-step-3
https://linear.app/getsentry/issue/CCMRG-440/cli-binary-step-3-install-cli-via-binary
https://linear.app/getsentry/issue/CCMRG-439/cli-pip-step-3-install-cli-via-pip
https://linear.app/getsentry/issue/CCMRG-436/gh-actions-repo-token-step-3-add-prevent-action-to-yaml
https://linear.app/getsentry/issue/CCMRG-434/gh-actions-oidc-step-3-add-prevent-action-to-yaml
I believe 138/434 and 142/436 are dupes.
Adds step 3 steps to TA onboarding:
Using GHA->Using Sentry Prevent Token flow
Using GHA->Using OIDC flow
Using Sentry Prevent's CLI
-> Using pip
-> Using a binary (slightly different from using pip)