Skip to content

ref(avatar): Remove barrel avatar #93735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025

Conversation

evanpurkhiser
Copy link
Member

Almost nothing was using this and we should just be explicitly rendering each type of avatar.

Almost nothing was using this and we should just be explicitly rendering
each type of avatar.
@evanpurkhiser evanpurkhiser requested review from a team as code owners June 17, 2025 18:48
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 17, 2025
@evanpurkhiser evanpurkhiser requested review from a team and removed request for a team June 17, 2025 18:54
hasTooltip
/>
)}
) : null}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was passing undefined to the UserAvatar before, which would just render null. See

if (!user) {
// @TODO(jonasbadalic): Do we need a placeholder here?
return null;
}

@evanpurkhiser evanpurkhiser merged commit 39eef6f into master Jun 17, 2025
46 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/ref-avatar-remove-barrel-avatar branch June 17, 2025 20:13
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
Almost nothing was using this and we should just be explicitly rendering
each type of avatar.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants