Skip to content

feat(dashboards): Add endpoint for reordering dashboard positions #93738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

narsaynorath
Copy link
Member

Adds functionality to support reordering dashboard positions. Expose the functionality through a new endpoint at /dashboards/starred/order/ to mimic issue views and explore queries.

Adds tests to cover cases such as basic reordering, error validation on duplicates or missing IDs, as well as allowing reordering even if positions aren't already set.

@narsaynorath narsaynorath requested review from a team as code owners June 17, 2025 18:50
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 17, 2025
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

Attention: Patch coverage is 97.75281% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...y/api/endpoints/organization_dashboards_starred.py 94.28% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #93738       +/-   ##
===========================================
+ Coverage   46.08%   84.56%   +38.47%     
===========================================
  Files       10309    10328       +19     
  Lines      595061   596041      +980     
  Branches    23137    23137               
===========================================
+ Hits       274240   504045   +229805     
+ Misses     320328    91503   -228825     
  Partials      493      493               

@narsaynorath narsaynorath merged commit fb0610f into master Jun 17, 2025
63 checks passed
@narsaynorath narsaynorath deleted the narsaynorath/dain-536-update-endpoint-to-modify-position-data branch June 17, 2025 19:31
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
…3738)

Adds functionality to support reordering dashboard positions. Expose the
functionality through a new endpoint at `/dashboards/starred/order/` to
mimic issue views and explore queries.

Adds tests to cover cases such as basic reordering, error validation on
duplicates or missing IDs, as well as allowing reordering even if
positions aren't already set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants