feat(auth-v2): Set up feature flag #93740
Open
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
mifu67
reviewed
Jun 17, 2025
| @@ -58,6 +58,8 @@ def register_temporary_features(manager: FeatureManager): | |||
| manager.add("organizations:anr-analyze-frames", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True) | |||
| # Rollout of the new API rate limits for organization events | |||
| manager.add("organizations:api-organization_events-rate-limit-reduced-rollout", OrganizationFeature, FeatureHandlerStrategy.INTERNAL, api_expose=False) | |||
| # Enables the frontend to use the new auth flow for specific users. | |||
| manager.add("organizations:auth-v2", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False) | |||
There was a problem hiding this comment.
If you want this to be used by FE, you must expose to the API
There was a problem hiding this comment.
It will not be used by the frontend to keep it simple, because you will not have the feature flag if you have not logged in. For the frontend, we'll hide it in a obscure route + check a LocalStorage value.
This flag protects the API from being called.
mifu67
approved these changes
Jun 17, 2025
cathteng
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/getsentry/sentry-options-automator/pull/4203