Skip to content

chore(taskworker): Update put child multiprocessing queue metric #93744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

enochtangg
Copy link
Member

There are two places we add an inflight task to the child queue. This PR makes sure that the metric gets captures in both places.

@enochtangg enochtangg requested a review from a team as a code owner June 17, 2025 19:56
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 17, 2025
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/taskworker/worker.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #93744   +/-   ##
=======================================
  Coverage   88.02%   88.02%           
=======================================
  Files       10330    10330           
  Lines      596117   596119    +2     
  Branches    23153    23153           
=======================================
+ Hits       524754   524758    +4     
+ Misses      70912    70910    -2     
  Partials      451      451           

@enochtangg enochtangg merged commit b813f6e into master Jun 18, 2025
65 checks passed
@enochtangg enochtangg deleted the update-child-task-metric branch June 18, 2025 14:15
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
)

There are two places we add an inflight task to the child queue. This PR
makes sure that the metric gets captures in both places.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants