ref: normalize slash matching regexes #93746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
in python escaping forward slash is not necessary so \/ does nothing -- normalize to not doing the unnecessary thing automated w/ ```bash git grep -E -l '\[\^\\\\?/\]' -- '*.py' | xargs sed -i -r 's|\[\^\\\\?/\]|[^/]|g' ```
asottile-sentry
force-pushed
the
asottile-no-need-to-escape-slash
branch
from
609af88 to
80efccf
Compare
kcons
approved these changes
Jun 17, 2025
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #93746 +/- ##
=======================================
Coverage 88.02% 88.02%
=======================================
Files 10330 10331 +1
Lines 596117 596142 +25
Branches 23153 23153
=======================================
+ Hits 524754 524780 +26
+ Misses 70912 70911 -1
Partials 451 451 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
in python escaping forward slash is not necessary so \\/ does nothing -- normalize to not doing the unnecessary thing automated w/ ```bash git grep -E -l '\[\^\\\\?/\]' -- '*.py' | xargs sed -i -r 's|\[\^\\\\?/\]|[^/]|g' ``` I'm doing this to better audit our urls for cellularization <!-- Describe your PR here. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in python escaping forward slash is not necessary so \/ does nothing -- normalize to not doing the unnecessary thing
automated w/
I'm doing this to better audit our urls for cellularization