chore(aci milestone 3): migrate edge case alerts #93749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
|
This PR has a migration; here is the generated SQL for for --
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL |
mifu67
commented
Jun 17, 2025
| AlertRuleTriggerActionType.SLACK.value: "Slack", | ||
| AlertRuleTriggerActionType.MSTEAMS.value: "Microsoft Teams", | ||
| AlertRuleTriggerActionType.OPSGENIE.value: "Opsgenie", | ||
| AlertRuleTriggerActionType.DISCORD.value: "Discord", |
There was a problem hiding this comment.
Made sure I didn't miss this this time 😅
Comment on lines
+532
to
+538
| # resolve action filter | ||
| DataCondition.objects.create( | ||
| comparison=PRIORITY_MAP.get(trigger.label, DetectorPriorityLevel.HIGH), | ||
| condition_result=True, | ||
| type=Condition.ISSUE_PRIORITY_DEESCALATING, | ||
| condition_group=data_condition_group, | ||
| ) |
There was a problem hiding this comment.
This was introduced after the initial migration, so added it here to avoid the need for a backfill
Comment on lines
+778
to
+787
| alert_rules = ( | ||
| AlertRule.objects_with_snapshots.filter( | ||
| status__in=[ | ||
| AlertRuleStatus.PENDING.value, | ||
| AlertRuleStatus.DISABLED.value, # we don't need to worry about NOT_ENOUGH_DATA here, because all anomaly detection alerts have been migrated | ||
| ] | ||
| ) | ||
| .filter(~Exists(AlertRuleDetector.objects.filter(alert_rule_id=OuterRef("id")))) | ||
| .filter(Exists(AlertRuleProjects.objects.filter(alert_rule_id=OuterRef("id")))) | ||
| ) |
There was a problem hiding this comment.
We're fetching all non-deleted alert rules that 1) have not been migrated and 2) have associated projects
Comment on lines
+806
to
+810
| enabled = ( | ||
| True | ||
| if snoozed is None and alert_rule.status == AlertRuleStatus.PENDING.value | ||
| else False | ||
| ) |
There was a problem hiding this comment.
Disable the detector if the alert rule is disabled
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #93749 +/- ##
===========================================
+ Coverage 46.09% 88.04% +41.95%
===========================================
Files 10309 10330 +21
Lines 594907 596553 +1646
Branches 23134 23134
===========================================
+ Hits 274198 525230 +251032
+ Misses 320215 70829 -249386
Partials 494 494 |
ceorourke
approved these changes
Jun 18, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
This migration creates ACI objects for the following alerts: - Alerts that were disabled during the initial migration but are now enabled - Alerts that were anomaly detection alerts and created before anomaly detection dual write was enabled, but became static/percent alerts before the anomaly detection alert migration - All disabled alert rules with projects to prevent future instances of case 1. These detectors will be set to disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migration creates ACI objects for the following alerts: