core: move flex under core/layout #93755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core: move flex under core
github-actions
bot
added
the
Scope: Frontend
JonasBa
commented
Jun 17, 2025
Comment on lines
-11
to
-15
| gap?: number | CssSize; | ||
| h?: number | CssSize; | ||
| gap?: CSSProperties['gap']; | ||
| justify?: CSSProperties['justifyContent']; | ||
| p?: number | CssSize; | ||
| w?: number | CssSize; |
There was a problem hiding this comment.
Aside from w having a single use, the rest were all unused
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93755 +/- ##
==========================================
- Coverage 88.03% 82.96% -5.07%
==========================================
Files 10328 10328
Lines 596102 596102
Branches 23146 23146
==========================================
- Hits 524763 494585 -30178
- Misses 70883 101061 +30178
Partials 456 456 |
|
Requires stacked changes from #93758 to be merged into this PR first. |
natemoo-re
approved these changes
Jun 17, 2025
This logic should have been inlined. Opening as a stacked PR to unblock knip on #93755
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
Move flex under core/layout, and cleanup the API (column bool -> direction=column + remove non flex style props)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move flex under core/layout, and cleanup the API (column bool -> direction=column + remove non flex style props)