-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
chore(sentry apps): Add SLOs for sentry app creation & updating #93762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93762 +/- ##
==========================================
+ Coverage 81.66% 88.06% +6.40%
==========================================
Files 10330 10337 +7
Lines 596288 596486 +198
Branches 23163 23108 -55
==========================================
+ Hits 486957 525303 +38346
+ Misses 108875 70690 -38185
- Partials 456 493 +37 |
REQUESTS = "requests" | ||
PUBLISH = "publish" | ||
WEBHOOK_UPDATE = "webhook_update" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these unused/future types?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeppers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! Looks good
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
No description provided.