Skip to content

chore(sentry apps): Add SLOs for sentry app creation & updating #93762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 18, 2025

Conversation

Christinarlong
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 17, 2025
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #93762      +/-   ##
==========================================
+ Coverage   81.66%   88.06%   +6.40%     
==========================================
  Files       10330    10337       +7     
  Lines      596288   596486     +198     
  Branches    23163    23108      -55     
==========================================
+ Hits       486957   525303   +38346     
+ Misses     108875    70690   -38185     
- Partials      456      493      +37     

@Christinarlong Christinarlong marked this pull request as ready for review June 18, 2025 22:32
@Christinarlong Christinarlong requested review from a team as code owners June 18, 2025 22:32
Comment on lines +133 to +135
REQUESTS = "requests"
PUBLISH = "publish"
WEBHOOK_UPDATE = "webhook_update"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these unused/future types?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeppers

Copy link
Member

@GabeVillalobos GabeVillalobos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Looks good

@Christinarlong Christinarlong merged commit 4dd52a3 into master Jun 18, 2025
63 checks passed
@Christinarlong Christinarlong deleted the crl/sentry-app-management-create branch June 18, 2025 22:43
Copy link

sentry-io bot commented Jun 19, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ValidationError: {"name":["Name Plane is already taken, please use another."]} /api/0/sentry-apps/ View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants