fix(spans): Write falsy values when converting to trace item in span buffer #93771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
untitaker
approved these changes
Jun 18, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
…buffer (#93771) The walrus operator `:=` in the conditional while renaming `sentry.` fields was skipping falsy values like `False` and `0`. This is significant in some cases like `duration_ms`, which might come back as `0` from Relay (that's a separate problem). There's a big difference here in whether the duration is unset vs. 0! Instead, manually check for `None` before writing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The walrus operator
:=in the conditional while renamingsentry.fields was skipping falsy values likeFalseand0. This is significant in some cases likeduration_ms, which might come back as0from Relay (that's a separate problem). There's a big difference here in whether the duration is unset vs. 0! Instead, manually check forNonebefore writing.