ref(aci): automation form cleanup #93775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
ameliahsu
commented
Jun 17, 2025
| type="text" | ||
| autoComplete="off" | ||
| /> | ||
| </StyledInputGroup> |
There was a problem hiding this comment.
the SearchBar was throwing errors about nesting a Form inside a Form, this is kind of a temporary fix since this search bar doesn't work right now anyways
scttcper
reviewed
Jun 18, 2025
scttcper
approved these changes
Jun 18, 2025
ameliahsu
force-pushed
the
mia/aci/ref-new-automation
branch
from
5a9f7ec to
9f98984
Compare
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
- extracting the `Form` from `AutomationForm` and wrapping `AutomationForm` with `FullHeightForm` inside of the new-settings page instead - updated Step 1 of automation creation so that the automation name is not editable - now passing connected monitor ids through query params instead of localStorage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FormfromAutomationFormand wrappingAutomationFormwithFullHeightForminside of the new-settings page instead