fix(wizard): Improve API responses from wizard API route #93787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This used to return a HTML page with weird content (e.g. spotlight stuff, ...) which lead to failures. Possibly this is just in local dev, but still. Now, this returns proper JSON that the frontend can also possibly use for better error messages etc.
mydea
requested review from
stephanie-anderson and
AbhiPrasad
and removed request for
a team
github-actions
bot
added
the
Scope: Backend
This was referenced Jun 18, 2025
ArthurKnaus
approved these changes
Jun 18, 2025
mydea
changed the title
mydea
added a commit
that referenced
this pull request
Jun 18, 2025
I noticed that the error messages are not displayed at all right now, I guess because the `Indicators` have been missing. So I added this, and while at it also added some more specific error message for the case when no active DSN can be found in the project. The DSN error is based on changed here: #93787 but this PR should work unrelated to that still (it will just never show this message).
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #93787 +/- ##
==========================================
- Coverage 88.02% 88.02% -0.01%
==========================================
Files 10332 10332
Lines 596302 596305 +3
Branches 23163 23163
==========================================
- Hits 524911 524904 -7
- Misses 70935 70945 +10
Partials 456 456 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
I noticed that the error messages are not displayed at all right now, I guess because the `Indicators` have been missing. So I added this, and while at it also added some more specific error message for the case when no active DSN can be found in the project. The DSN error is based on changed here: #93787 but this PR should work unrelated to that still (it will just never show this message).
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
This used to return a HTML page with weird content (e.g. spotlight stuff, ...) which lead to failures. Possibly this is just in local dev, but still. Now, this returns proper JSON that the frontend can also possibly use for better error messages etc. Importantly, this used to fail from the frontends perspective even for `HttpResponse(status=200)` because it included some weird HTML that it was apparently not expecting. By returning JSON this should be fixed. (I _think_ this is only on dev because of spotlight...) Noticed this while working on #93697
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used to return a HTML page with weird content (e.g. spotlight stuff, ...) which lead to failures. Possibly this is just in local dev, but still. Now, this returns proper JSON that the frontend can also possibly use for better error messages etc.
Importantly, this used to fail from the frontends perspective even for
HttpResponse(status=200)because it included some weird HTML that it was apparently not expecting. By returning JSON this should be fixed. (I think this is only on dev because of spotlight...)Noticed this while working on #93697