fix(ui): chart colors in stats usage page #93789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-colors-in-stats-usage-page
github-actions
bot
added
the
Scope: Frontend
Jesse-Box
approved these changes
Jun 18, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
This PR: - removes the `theme.outcome` values, as we don’t want to have page specific things on the generic theme - this was also the reason why charting was wrong in chonk because we were always using the legacy colors, as `theme.outcome` wasn’t overwritten in the chonk theme, so it was still referencing the old colors. For `chonk`, we are now simply creating a color palette without hard-coded colors, as discussed with @Jesse-Box. | before | after | |--------|--------| |  |  | |  |  | Note: I’ve additionally removed the hardcoded mapping for the `reservedUsageChart`, as the outcome colors now no longer exist on the theme. This _does_ impact the current chart in the legacy theme, too: before: | dark | light | |--------|--------| |  |  | after: | dark | light | |--------|--------| |  |  | |  |  |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
theme.outcomevalues, as we don’t want to have page specific things on the generic themetheme.outcomewasn’t overwritten in the chonk theme, so it was still referencing the old colors.For
chonk, we are now simply creating a color palette without hard-coded colors, as discussed with @Jesse-Box.Note: I’ve additionally removed the hardcoded mapping for the
reservedUsageChart, as the outcome colors now no longer exist on the theme. This does impact the current chart in the legacy theme, too:before:
after: