Skip to content

fix(colors): fix chart colors after getColorPalette was updated #93791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2025
Merged

fix(colors): fix chart colors after getColorPalette was updated #93791

merged 1 commit into from
Jun 18, 2025
+3 −6

Conversation

shellmayr
Copy link
Member

  • fix: getColorPalette indexing #93699 changed the returned number of colors for getColorPalette. Other code depended on this - as indicated by comments, which broke some charts (missing colors, same colors).
  • This PR adapts the parameters to make charts look like they should again

Before:
Screenshot 2025-06-18 at 10 57 29

After:
Screenshot 2025-06-18 at 10 57 20

@shellmayr shellmayr requested review from a team as code owners June 18, 2025 08:59
@shellmayr shellmayr requested a review from a team June 18, 2025 08:59
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 18, 2025
@shellmayr shellmayr merged commit 0652bf8 into master Jun 18, 2025
46 checks passed
@shellmayr shellmayr deleted the shellmayr/fix/chart-colors branch June 18, 2025 09:36
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
@shellmayr @andrewshie-sentry
fix(colors): fix chart colors after getColorPalette was updated (#93791)
4a2a572
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TkDodo TkDodo TkDodo approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shellmayr @TkDodo