fix(colors): discover chart colors after getColorPalette update #93792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
TkDodo
approved these changes
Jun 18, 2025
TkDodo
reviewed
Jun 18, 2025
| @@ -106,7 +106,7 @@ function AggregatesTable({ | |||
|
|
|||
| const numberOfRowsNeedingColor = Math.min(result.data?.length ?? 0, TOP_EVENTS_LIMIT); | |||
|
|
|||
| const palette = theme.chart.getColorPalette(numberOfRowsNeedingColor - 2); // -2 because getColorPalette artificially adds 1, I'm not sure why | |||
| const palette = theme.chart.getColorPalette(numberOfRowsNeedingColor); | |||
There was a problem hiding this comment.
shouldn’t this still be -1 then?
There was a problem hiding this comment.
did that here: 6ea7821
the whole logic is a bit weird though because looking at numberOfRowsNeedingColor, we could get 0 back from that calculation:
const numberOfRowsNeedingColor = Math.min(result.data?.length ?? 0, TOP_EVENTS_LIMIT);
which means we’d go into the negative here, so palette would be undefined then :/
TkDodo
reviewed
Jun 18, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and some more in tables, etc.