fix: Busy button should display wait cursor and have aria-busy #93793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
obostjancic
approved these changes
Jun 18, 2025
TkDodo
approved these changes
Jun 18, 2025
There was a problem hiding this comment.
@getsentry/design-engineering I would probably like to streamline the API for busy and disabled a bit. Currently its two booleans, but can you really be in both states? We sometimes set both flags:
sentry/static/app/views/acceptOrganizationInvite/index.tsx
Lines 70 to 71 in 27ba1e6
so which cursor you then get depends on how its implemented ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was unable to make my cursor appear in my recordings, so unfortunately, there are no before-and-after images.