feat: Show busy trace button until trace is received #93794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priscilawebdev
changed the title
github-actions
bot
added
the
Scope: Frontend
priscilawebdev
commented
Jun 18, 2025
Comment on lines
+495
to
+505
| const dataset = useExploreDataset(); | ||
| const tracesQuery = useTraces({ | ||
| enabled: received, | ||
| limit: 1, | ||
| dataset, | ||
| sort: 'timestamp', | ||
| refetchInterval: query => { | ||
| const trace = query.state.data?.[0]?.data?.[0]?.trace; | ||
| return trace ? false : 5000; // 5s | ||
| }, | ||
| }); |
There was a problem hiding this comment.
Similar to what's used here and by the table component.
Comment on lines
+760
to
+764
| const params = new URLSearchParams(window.location.search); | ||
| params.set('table', Tab.TRACE); | ||
| params.set('query', `trace:${traceId}`); | ||
| params.delete('guidedStep'); | ||
| window.location.href = `${window.location.pathname}?${params.toString()}`; |
There was a problem hiding this comment.
with the new changes, there was a glitch and window.location.href solves the issue
| }} | ||
| > | ||
| {t('Take me to traces')} | ||
| {t('Take me to my trace')} |
There was a problem hiding this comment.
since we are now setting trace to the query, this can be named 'take me to my trace', similar to 'take me to my profiling'
Abdkhan14
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://linear.app/getsentry/issue/TET-589/take-me-to-traces-button-should-should-wait-for-the-first-event-and
Preview
Screen.Recording.2025-06-18.at.10.29.55.mov