Skip to content

fix(colors): insights charts #93796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2025
Merged

fix(colors): insights charts #93796

merged 1 commit into from
Jun 18, 2025

Conversation

shellmayr
Copy link
Member

@shellmayr shellmayr commented Jun 18, 2025 •
edited
Loading

  • fix: getColorPalette indexing #93699 changed the returned number of colors for getColorPalette. Other code depended on this - as indicated by comments, which broke some charts (missing colors, same colors).
  • Fix chart colors on web vitals, mobile page

Example Before:
Screenshot 2025-06-18 at 12 47 53

Example After:
Screenshot 2025-06-18 at 12 47 51

@shellmayr shellmayr requested review from a team as code owners June 18, 2025 10:47
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 18, 2025
@shellmayr shellmayr requested review from a team June 18, 2025 10:50
@shellmayr shellmayr enabled auto-merge (squash) June 18, 2025 10:56
@shellmayr shellmayr merged commit 4a7ea25 into master Jun 18, 2025
47 checks passed
@shellmayr shellmayr deleted the shellmayr/fix/insights-chart-colors branch June 18, 2025 10:59
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
@shellmayr @andrewshie-sentry
fix(colors): insights charts (#93796)
ad7aefe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TkDodo TkDodo TkDodo approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shellmayr @TkDodo