Skip to content

fix(ui): button is cut-off in chonk #93797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

TkDodo
Copy link
Contributor

@TkDodo TkDodo commented Jun 18, 2025

there's no apparent reason why we'd need overflowEllipsis in a column that shows a button, and line-height doesn't change anything either from what I an see

before after
Screenshot 2025-06-18 at 13 23 32 Screenshot 2025-06-18 at 13 23 20
Screenshot 2025-06-18 at 13 23 29 Screenshot 2025-06-18 at 13 23 14

there's no apparent reason why we'd need overflowEllipsis in a column that shows a button, and line-height doesn't change anything either from what I an see
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 18, 2025
@TkDodo TkDodo marked this pull request as ready for review June 18, 2025 11:28
@TkDodo TkDodo requested a review from a team as a code owner June 18, 2025 11:28
@TkDodo TkDodo requested a review from a team June 18, 2025 11:28
@TkDodo TkDodo merged commit b9d68fa into master Jun 18, 2025
47 checks passed
@TkDodo TkDodo deleted the tkdodo/fix/de-152-button-cut-off-in-releases-list branch June 18, 2025 15:59
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
there's no apparent reason why we'd need overflowEllipsis in a column
that shows a button, and line-height doesn't change anything either from
what I an see

| before | after |
|--------|--------|
| ![Screenshot 2025-06-18 at 13 23
32](https://github.com/user-attachments/assets/e4fd4805-b01e-4b7e-a33e-7a7867415fad)
| ![Screenshot 2025-06-18 at 13 23
20](https://github.com/user-attachments/assets/157aa163-2c65-4170-8beb-26d02a33c5bd)
|
| ![Screenshot 2025-06-18 at 13 23
29](https://github.com/user-attachments/assets/00d6654a-5aae-4d03-923b-bf62988735d0)
| ![Screenshot 2025-06-18 at 13 23
14](https://github.com/user-attachments/assets/dbf494c4-307a-47ec-8726-f280f6790f57)
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants