Skip to content

ref: move interactionStateLayer to components/core #93798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

TkDodo
Copy link
Contributor

@TkDodo TkDodo commented Jun 18, 2025

No description provided.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 18, 2025
Comment on lines 26 to 29
/**
* @deprecated
*/
const InteractionStateLayer = styled(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JonasBa @natemoo-re As discussed, I’d like to deprecate this component because we don’t want an extra element for “states” that we can also do with css.

However, the theme docs have a couple of deprecated values which want us to use InteractionStateLayer instead:

/**
* Indicates a "hover" state. Deprecated – use `InteractionStateLayer` instead for
* interaction (hover/press) states.
* @deprecated
*/
hover: colors.surface500,

Do we un-deprecate them or what is the way forward if we want hover/pressed/active states?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we would remove these in favor of component, but I'm not sure how large of a task that is. I think we are ok leaving it deprecated for now though. Folks should rarely (if ever) have to use these hover styles imo, so getting entirely away from them is the best in my view.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the message here: ba9f86b

TkDodo added 2 commits June 19, 2025 11:51
# Conflicts:
#	static/app/components/feedback/list/feedbackListItem.tsx
#	static/app/components/onboardingWizard/content.tsx
#	static/app/components/sidebar/sidebarItem.tsx
#	static/app/components/workflowEngine/form/control/priorityControl.tsx
#	static/app/views/detectors/components/detectorListTable/detectorListRow.tsx
@TkDodo TkDodo marked this pull request as ready for review June 19, 2025 09:54
@TkDodo TkDodo requested review from a team as code owners June 19, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants