-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
ref: move interactionStateLayer to components/core #93798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
/** | ||
* @deprecated | ||
*/ | ||
const InteractionStateLayer = styled( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JonasBa @natemoo-re As discussed, I’d like to deprecate this component because we don’t want an extra element for “states” that we can also do with css.
However, the theme
docs have a couple of deprecated values which want us to use InteractionStateLayer
instead:
sentry/static/app/utils/theme/theme.tsx
Lines 348 to 353 in 2958ad9
/** | |
* Indicates a "hover" state. Deprecated – use `InteractionStateLayer` instead for | |
* interaction (hover/press) states. | |
* @deprecated | |
*/ | |
hover: colors.surface500, |
Do we un-deprecate them or what is the way forward if we want hover/pressed/active states?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, we would remove these in favor of component, but I'm not sure how large of a task that is. I think we are ok leaving it deprecated for now though. Folks should rarely (if ever) have to use these hover styles imo, so getting entirely away from them is the best in my view.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update the message here: ba9f86b
# Conflicts: # static/app/components/feedback/list/feedbackListItem.tsx # static/app/components/onboardingWizard/content.tsx # static/app/components/sidebar/sidebarItem.tsx # static/app/components/workflowEngine/form/control/priorityControl.tsx # static/app/views/detectors/components/detectorListTable/detectorListRow.tsx
No description provided.