Drop EventAttachment.file_id, part 1
#93806
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93806 +/- ##
===========================================
+ Coverage 46.06% 88.02% +41.95%
===========================================
Files 10323 10339 +16
Lines 595898 596635 +737
Branches 23171 23171
===========================================
+ Hits 274521 525202 +250681
+ Misses 320918 70974 -249944
Partials 459 459 |
Swatinem
force-pushed
the
swatinem/rm-eventattachment-fileid-part1
branch
from
87208ad to
1aa35a4
Compare
Swatinem
force-pushed
the
swatinem/rm-eventattachment-fileid-part2
branch
from
2efed5e to
fa3be1a
Compare
|
This PR has a migration; here is the generated SQL for for --
-- Moved eventattachment.file_id field to pending deletion state
--
-- (no-op) |
Swatinem
force-pushed
the
swatinem/rm-eventattachment-fileid-part1
branch
2 times, most recently
from
86da06d to
27ebb34
Compare
jan-auer
approved these changes
Jun 18, 2025
Base automatically changed from
swatinem/rm-eventattachment-fileid-part1
to
master
June 18, 2025 16:08
Swatinem
force-pushed
the
swatinem/rm-eventattachment-fileid-part2
branch
from
fa3be1a to
1630998
Compare
|
This PR has a migration; here is the generated SQL for for --
-- Moved eventattachment.file_id field to pending deletion state
--
-- (no-op) |
First part of dropping the column, marking it as pending.
Swatinem
force-pushed
the
swatinem/rm-eventattachment-fileid-part2
branch
from
1630998 to
f99f0b1
Compare
vgrozdanic
approved these changes
Jun 18, 2025
wedamija
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of dropping the column, marking it as pending.