Skip to content

ref(dashboards): replace table widget with standardized table #93810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

lzhao-sentry
Copy link
Contributor

@lzhao-sentry lzhao-sentry commented Jun 18, 2025

Changes

Create a new table widget that uses GridEditable as the underlying component. Replaces widgets in the dashboard and widget preview. Sorting, resizing and replacing the table of the widget preview modal will be added in different PRs.

This change relies on #93704 being merged in first (which fixes some style issues)

Before/After

There is no visual change except that column dividers appear when hovering over a table widget in dashboards/preview (this is in preparation for column resizing)

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 18, 2025
Copy link

codecov bot commented Jun 18, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
10573 1 10572 9
View the top 1 failed test(s) by shortest run time
Dashboards > IssueWidgetCard maps lifetimeEvents and lifetimeUsers headers to more human readable
Stack Traces | 1.07s run time
Error: Unable to find an element with the text: Lifetime Events. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
...
    at waitForWrapper (.../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/wait-for.js:163:27)
    at .../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/query-helpers.js:86:33
    at Object.<anonymous> (.../dashboards/widgetCard/issueWidgetCard.spec.tsx:238:46)
    at Promise.then.completed (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/run.js:316:40)
    at _runTest (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/run.js:121:9)
    at run (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/node_modules/.pnpm/[email protected][email protected]..../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/node_modules/.pnpm/[email protected][email protected]..../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/testWorker.js:106:12)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@lzhao-sentry lzhao-sentry marked this pull request as ready for review June 18, 2025 17:27
@lzhao-sentry lzhao-sentry requested review from a team as code owners June 18, 2025 17:27
@lzhao-sentry lzhao-sentry marked this pull request as draft June 18, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant