-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
ref(dashboards): replace table widget with standardized table #93810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
lzhao-sentry
wants to merge
5
commits into
master
Choose a base branch
from
lzhao/add-basic-table-widget-using-grideditable
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
ref(dashboards): replace table widget with standardized table #93810
lzhao-sentry
wants to merge
5
commits into
master
from
lzhao/add-basic-table-widget-using-grideditable
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Create a new table widget that uses
GridEditable
as the underlying component. Replaces widgets in the dashboard and widget preview. Sorting, resizing and replacing the table of the widget preview modal will be added in different PRs.This change relies on #93704 being merged in first (which fixes some style issues)
Before/After
There is no visual change except that column dividers appear when hovering over a table widget in dashboards/preview (this is in preparation for column resizing)