feat(dashboards): Add GET endpoint for starred dashboards #93812
+122
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This endpoint will be where I query for the starred data. It should return dashboards in order of how they are positioned. In a follow up PR I will add code here such that if there are any `None` positions, I'll trigger a backfill and update them given the ordering of their name, which is the current ordering in the sidebar.
github-actions
bot
added
the
Scope: Backend
…solating-starred-query-logic
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #93812 +/- ##
==========================================
- Coverage 88.02% 88.02% -0.01%
==========================================
Files 10331 10331
Lines 596415 596464 +49
Branches 23160 23160
==========================================
+ Hits 524992 525032 +40
- Misses 70967 70976 +9
Partials 456 456 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This endpoint will be where I query for the starred data. It should return dashboards in order of how they are positioned.
In a follow up PR I will add code here such that if there are any
Nonepositions, I'll trigger a backfill and update them given the ordering of their name, which is the current ordering in the sidebar.