fix(browser-report): Adjust code to specification #93818
Merged
+132
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the expected data to match [the specification](https://www.w3.org/TR/reporting/#concept-reports).
github-actions
bot
added
the
Scope: Backend
armenzg
commented
Jun 18, 2025
| report_type = report.get("type") | ||
| metrics.incr( | ||
| "browser_reporting.raw_report_received", | ||
| tags={"browser_report_type": report_type}, |
There was a problem hiding this comment.
I'm also changing the tag.
roggenkemper
approved these changes
Jun 18, 2025
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #93818 +/- ##
=======================================
Coverage 88.02% 88.02%
=======================================
Files 10331 10331
Lines 596425 596453 +28
Branches 23160 23160
=======================================
+ Hits 524995 525028 +33
+ Misses 70974 70969 -5
Partials 456 456 |
Comment on lines
+35
to
+43
| @dataclass | ||
| class BrowserReport: | ||
| body: dict[str, Any] | ||
| type: BrowserReportType | ||
| url: str | ||
| user_agent: str | ||
| destination: str | ||
| timestamp: int | ||
| attempts: int |
There was a problem hiding this comment.
I believe you're looking at the wrong source for your list of fields. These are the fields in the report object generated by the browser, but not the ones in the serialized report that's sent. See also the sample reports in the spec (which match what my test app sends).
| browser_report = BrowserReport(**report) | ||
| metrics.incr( | ||
| "browser_reporting.raw_report_received", | ||
| tags={"browser_report_type": browser_report.type}, |
There was a problem hiding this comment.
Don't we have the same issue here as before? Of a rogue actor potentially sending arbitrary values?
There was a problem hiding this comment.
Types aren't checked at runtime, though, are they?
Comment on lines
+18
to
+32
| { | ||
| "body": { | ||
| "columnNumber": 12, | ||
| "id": "RangeExpand", | ||
| "lineNumber": 31, | ||
| "message": "Range.expand() is deprecated. Please use Selection.modify() instead.", | ||
| "sourceFile": "https://dogs.are.great/_next/static/chunks/_4667019e._.js", | ||
| }, | ||
| "type": "deprecation", | ||
| "url": "https://dogs.are.great/", | ||
| "user_agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/137.0.0.0 Safari/537.36", | ||
| "destination": "default", | ||
| "timestamp": 1640995200000, # January 1, 2022 in milliseconds | ||
| "attempts": 1, | ||
| } |
There was a problem hiding this comment.
See above re: the list of fields here.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
This updates the expected data to match [the specification](https://www.w3.org/TR/reporting/#concept-reports).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the expected data to match the specification.