fix(dashboards-comparison): Add proper handling for environment filters #93822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93822 +/- ##
==========================================
- Coverage 88.02% 88.02% -0.01%
==========================================
Files 10331 10331
Lines 596378 596443 +65
Branches 23160 23160
==========================================
+ Hits 524976 525015 +39
- Misses 70946 70972 +26
Partials 456 456 |
shruthilayaj
approved these changes
Jun 18, 2025
nikkikapadia
deleted the
nikki/fix/environment-setup-dash-comparison-script
branch
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
…rs (#93822) We were getting a bunch of `'str' object has no attribute 'name'` errors in both metrics and eap queries on the de job run. I think it may be due to how we previously handled the environment filters, so i've fixed that in the script and added a test for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were getting a bunch of
'str' object has no attribute 'name'errors in both metrics and eap queries on the de job run. I think it may be due to how we previously handled the environment filters, so i've fixed that in the script and added a test for it.